Use a searchbar similar to the one in okular using the webenginepart
ClosedPublic

Authored by ognarb on Mar 8 2019, 7:13 PM.

Diff Detail

Repository
R226 Konqueror
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ognarb requested review of this revision.Mar 8 2019, 7:13 PM
ognarb created this revision.
ognarb edited the summary of this revision. (Show Details)
ognarb planned changes to this revision.Mar 8 2019, 9:40 PM
This comment was removed by ognarb.
ognarb requested review of this revision.Mar 8 2019, 10:27 PM
ognarb updated this revision to Diff 53487.Mar 8 2019, 11:11 PM
  • Remove label
  • Add placeholderText and clearButton
ognarb edited the summary of this revision. (Show Details)Mar 14 2019, 1:08 PM
ognarb updated this revision to Diff 53881.Mar 14 2019, 1:22 PM

Add setting icon to config button

ognarb updated this revision to Diff 53907.Mar 14 2019, 6:43 PM

Remove icon for options button

ognarb updated this revision to Diff 53913.Mar 14 2019, 7:18 PM

After discution in VDG group, add configure button again ;)

ognarb edited the test plan for this revision. (Show Details)Mar 14 2019, 7:22 PM
ognarb updated this revision to Diff 53929.Mar 14 2019, 10:16 PM

Use unicode ellipsis

GB_2 added a subscriber: GB_2.EditedSep 21 2019, 4:08 PM

Please use three dots which we always use instead of the unicode ellipsis.

dfaure added a subscriber: dfaure.

@stefanocrocco do you want to test this and integrate it if it works? Looks like it got rather forgotten over time.

ognarb updated this revision to Diff 80162.Apr 14 2020, 9:08 PM
  • use ...
ognarb added a comment.EditedApr 14 2020, 9:09 PM

I completely forgot it too :/

@stefanocrocco do you want to test this and integrate it if it works? Looks like it got rather forgotten over time.

It works and it looks good. I don't understand what you mean by "integrate", however.

dfaure accepted this revision.Apr 16 2020, 6:50 PM

Right. This was in case the code had changed meanwhile and the original author was unresponsive (looks like I was wrong on both accounts).
If it applies and still makes sense as is, no problems ;)

This revision is now accepted and ready to land.Apr 16 2020, 6:50 PM
This revision was automatically updated to reflect the committed changes.