Support NET_WM_STATE_FOCUSED
ClosedPublic

Authored by davidedmundson on Mar 8 2019, 4:37 PM.

Details

Test Plan

Used in kwin
Unit test

Diff Detail

Repository
R278 KWindowSystem
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Mar 8 2019, 4:37 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 8 2019, 4:37 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Mar 8 2019, 4:37 PM
zzag added a subscriber: zzag.Mar 8 2019, 5:45 PM
zzag added inline comments.
src/netwm_def.h
506

5.56 or 5.57?

davidedmundson added inline comments.Mar 8 2019, 5:59 PM
src/netwm_def.h
506

Whatever I put in @since is always wrong by the time I commit it anyway

apol added a subscriber: apol.Mar 8 2019, 6:17 PM

+1 otherwise

autotests/netwininfotestwm.cpp
440

Indent with the rest? :P

ngraham added a subscriber: ngraham.Mar 8 2019, 7:01 PM
ngraham added inline comments.
src/netwm_def.h
506

It's 5.57; 5.56 has already been tagged.

broulik accepted this revision.Apr 29 2019, 1:27 PM
broulik added a subscriber: broulik.

I think regardless of whether we end up using this in KWin or not, we should have the API for it in KWindowSystem

This revision is now accepted and ready to land.Apr 29 2019, 1:27 PM
ngraham added inline comments.Apr 29 2019, 1:43 PM
src/netwm_def.h
506

5.58 at this point.

This revision was automatically updated to reflect the committed changes.