Differential D1961

[server] Add resource check in QtExtendedSurfaceInterface::close
ClosedPublic
Actions

Authored by graesslin on Jun 20 2016, 2:27 PM.

Details

Reviewers
sebas
Group Reviewers
Plasma on Wayland
Commits
R127:9ca4f8549f6e: [server] Add resource check in QtExtendedSurfaceInterface::close
Summary

The QtExtendedSurfaceInterface might be unbound and thus the resource
might be null when calling into close. Thus we need to do a nullptr
check.

Hit a crash there.

Test Plan

Unfortunately no test case as we don't have a client side
implementation for this.

Diff Detail

Repository
R127 KWayland
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 4641.Jun 20 2016, 2:27 PM
graesslin retitled this revision from to [server] Add resource check in QtExtendedSurfaceInterface::close.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added a reviewer: Plasma on Wayland.
Restricted Application added a project: Plasma on Wayland. · View Herald TranscriptJun 20 2016, 2:27 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sebas accepted this revision.Jun 20 2016, 2:27 PM
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.Jun 20 2016, 2:27 PM
Closed by commit R127:9ca4f8549f6e: [server] Add resource check in QtExtendedSurfaceInterface::close (authored by graesslin). · Explain WhyJun 20 2016, 2:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 4642

View Options

src/server/qtsurfaceextension_interface.cpp

Loading...