Differential D19609

[sddm-theme/lock screen] Improve appearance in software rendering mode (outlines and icons)
ClosedPublic
Actions

Authored by rooty on Mar 8 2019, 1:41 PM.

Details

Reviewers
ngraham
filipf
Group Reviewers
Plasma
VDG
Maniphest Tasks
T10325: 5.16 Login screen improvements
Commits
R120:aca7fd387307: [sddm-theme/lock screen] Improve appearance in software rendering mode…
Summary

This patch improves the appearance of the sddm theme and the lock screen with software rendering in place (QT_QUICK_BACKEND=software) by adding an outline to the action buttons, correcting the error that prevented the username outline from appearing and by adding a background to the action buttons that are otherwise impossible to see on top of a very bright background in software rendering mode.

Test Plan

Before (white background):


After (white background):

Before (Next):

After (Next):

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rooty created this revision.Mar 8 2019, 1:41 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 8 2019, 1:41 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
rooty requested review of this revision.Mar 8 2019, 1:41 PM
rooty edited the test plan for this revision. (Show Details)Mar 8 2019, 1:42 PM
rooty added reviewers: Plasma, VDG, ngraham, filipf.
rooty edited the summary of this revision. (Show Details)Mar 8 2019, 3:09 PM
ngraham added inline comments.Mar 8 2019, 10:11 PM
lookandfeel/contents/components/ActionButton.qml
85

Why do we need to change this when using software rendering?

90

Instead of "transparent", perhaps undefined would be better because there won't be a style for it anyway.

lookandfeel/contents/components/UserDelegate.qml
171

Ditto

rooty marked 3 inline comments as done.Mar 9 2019, 3:41 AM
rooty added inline comments.
lookandfeel/contents/components/ActionButton.qml
85

Because I feel that the icon looks too stuck-on if the margin's too great.

90

That causes an error, see D19577

rooty updated this revision to Diff 53490.Mar 9 2019, 3:48 AM
rooty marked 2 inline comments as done and an inline comment as not done.

Use less of a margin, rebase

rooty marked 3 inline comments as done.Mar 9 2019, 3:51 AM

I know it sounds strange but no value other than undefined causes the D19577 error... we could technically put "red" there because there's no outline to begin with and it'd look the same haha

I'm still not sure about the margin change, but it looks a too close for comfort without the margin if the circle's right from the start

ngraham accepted this revision.Mar 9 2019, 6:50 AM

All right, makes sense and looks good!

This revision is now accepted and ready to land.Mar 9 2019, 6:50 AM
Closed by commit R120:aca7fd387307: [sddm-theme/lock screen] Improve appearance in software rendering mode… (authored by rooty). · Explain WhyMar 9 2019, 6:51 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 53496

View Options

lookandfeel/contents/components/ActionButton.qml

Loading...
View Options

lookandfeel/contents/components/UserDelegate.qml

Loading...