as the implicit height could change when switching to password mode,
use a textmetrics which always computes it from the visible text
BUG:399155
ngraham | |
rooty |
Plasma |
as the implicit height could change when switching to password mode,
use a textmetrics which always computes it from the visible text
BUG:399155
height doesn't change
No Linters Available |
No Unit Test Coverage |
Buildable 9332 | |
Build 9350: arc lint + arc unit |
It's fixed!!!!
Of course now the issue with the dots is worse since the dots are just too high up in the text field:
However that's an issue in Noto Symbols itself. Aoparently all the characters in the whole font have a descent value that's too large (7 vs 4 for in regular Noto Sans). We're tracking this with https://github.com/googlei18n/noto-fonts/issues/1468. Thanks so much for fixing this, Marco!
Good things come to those who wait, thanks for the fix.
I can also confirm that this doesn't affect any other font adversely in any way.
LGTM, but do we need the MMM there? Wouldn't one M do? Or if control.text is always a string we don't need the ""+ at all?
src/declarativeimports/plasmastyle/TextFieldStyle.qml | ||
---|---|---|
60–61 | maybe add a linebreak between the two sides so it's easy to spot the metrics.height on both sides of the max. |