- Improve readability, const correctness
- const QChar as value, not reference
BUG:405089
BUG:382960
FIXED-IN: 5.57
Details
Details
- Reviewers
cullmann mwolff - Group Reviewers
KTextEditor - Commits
- R39:714948cac1d1: DocumentPrivate: Skip auto quotes when these looks already balanced
Try to type this in a C++ file:
('\'') => ended up in something like: ('\''')
Try to add afterwarnds double quotes to some word in a text, without to select the word:
foo "bar" haz => ended up in something like: foo "bar"" haz- Autotest looks good
- Contains partial code from unloved D17693 which is here only added to became it in. See latter two Summary notes
- Is the fix-in number right?
Diff Detail
Diff Detail
- Repository
- R39 KTextEditor
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
- Add KateDocumentTest::testAutoBrackets
Just a note to the current RegEx solution:
It's done as you see in a slightly redundant dumb way. Perhaps is a special function without regex faster?
Comment Actions
Given we have some test that ensures the new behavior is not broken again, I have no issues with merging this.
Did you get your account yet or shall I push?