Differential D19586

[CopyJob] Treat URL as dirty when renaming file as conflict resolution
ClosedPublic
Actions

Authored by broulik on Mar 7 2019, 10:15 AM.

Details

Reviewers
dfaure
chinmoyr
Commits
R241:51ba55f2c5cc: Remove URLs being fetched when listing job is completed
R241:2404693b9975: [CopyJob] Treat URL as dirty when renaming file as conflict resolution
Summary

When a file already exists and user choses to rename the file, the URL wasn't updated.
This lead to the job potentially still showing the old destination when finished.

Test Plan

See D19585

Opened Dolphin, Ctrl+C on a file, Ctrl+V it into the same folder, let it sit at the "Override?" prompt until the job view in Plasma showed up. Chose a different filename and continued.

With this, the destination URL reflects the rename and points to the actual file copied.

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mar 7 2019, 10:15 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 7 2019, 10:15 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Mar 7 2019, 10:15 AM
broulik edited reviewers, added: chinmoyr; removed: chingku.
dfaure accepted this revision.Mar 9 2019, 10:18 AM
This revision is now accepted and ready to land.Mar 9 2019, 10:18 AM
Closed by commit R241:2404693b9975: [CopyJob] Treat URL as dirty when renaming file as conflict resolution (authored by broulik). · Explain WhyMar 11 2019, 10:40 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/core/copyjob.cpp (1 line)

Diff 53640

View Options

src/core/copyjob.cpp

Loading...