It is not really meant to be changing after the job started, but there can be instances where the job first has to examine the real destination and only can then set it and start.
This patch ensures that at least when the job has finished, the destUrl is correct so that the job view can provide a more useful finished notification.
Details
Details
In plasma-browser-integration I only get the destination after the job has been started.
Now the destUrl I have in plasma notifications is correct when the job is finished
Diff Detail
Diff Detail
- Repository
- R288 KJobWidgets
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Looks ok, but the commit log is missing an actual use case. In which case does the dest URL change, exactly?
Comment Actions
Isn't "where the job first has to examine the real destination and only can then set it and start." and "In plasma-browser-integration I only get the destination after the job has been started." sufficient?
Comment Actions
I must be missing something.
How can a job "examine the real destination" without having the URL of the destination?
Is there some redirection happening or something?
Comment Actions
In plasma-browser-integration I get a download started event by the browser right away and only when the user chose a download location I will get notified of that, so the job does not have a destUrl in the beginning.
Comment Actions
Ah! See that's the information I was missing (download job + user chooses interactively). In KIO we typically ask for a dest first, and only then start a job.
If you could add a word in the commit log about the fact that user chooses interactively the dest as part of the job itself, that would be ideal.