Differential D19579

Improve wording of split view/pane settings
ClosedPublic
Actions

Authored by sdepiets on Mar 7 2019, 8:09 AM.

Details

Reviewers
angeloevertonjr
ngraham
Group Reviewers
Dolphin
Commits
R318:c148eff8ca34: Improve wording of split view/pane settings
Summary

I found these strings very hard to understand then translate without looking into the code because the use of "view" refers to both "the split view" and "the left pane and the right pane of the split view".

This patch attempts to explicitly mention panes when needed.

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sdepiets created this revision.Mar 7 2019, 8:09 AM
Restricted Application added a project: Dolphin. · View Herald TranscriptMar 7 2019, 8:09 AM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
sdepiets requested review of this revision.Mar 7 2019, 8:09 AM
sdepiets edited the summary of this revision. (Show Details)Mar 7 2019, 8:13 AM
sdepiets added reviewers: Dolphin, angeloevertonjr.
ngraham added a subscriber: ngraham.Mar 7 2019, 2:36 PM
ngraham added inline comments.
src/settings/general/behaviorsettingspage.cpp
100

panes of split view could be split view panes

sdepiets updated this revision to Diff 53370.Mar 7 2019, 3:38 PM

Implement suggestion

sdepiets marked an inline comment as done.Mar 7 2019, 3:38 PM
ngraham accepted this revision.Mar 7 2019, 4:36 PM
This revision is now accepted and ready to land.Mar 7 2019, 4:36 PM
Closed by commit R318:c148eff8ca34: Improve wording of split view/pane settings (authored by sdepiets). · Explain WhyMar 8 2019, 1:27 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 53399

View Options

src/settings/dolphin_generalsettings.kcfg

Loading...
View Options

src/settings/general/behaviorsettingspage.cpp

Loading...