Differential D19578

tagme: Do not use git push --tags
ClosedPublic
Actions

Authored by kfunk on Mar 7 2019, 7:26 AM.

Details

Reviewers
sitter
bcooksley
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
R572:1ac3decab112: tagme: Do not use git push --tags
Summary

It's dangerous, as it will push all local tags. Getting rid off unwanted
tags on the remote is not the best type of work to start your day...

Use git push origin <tag_name> instead, which will only push the
desired tag.

As has happened in kdevelop.git

Diff Detail

Repository
R572 releaseme
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kfunk created this revision.Mar 7 2019, 7:26 AM
Owners added a reviewer: Restricted Owners Package.Mar 7 2019, 7:26 AM
kfunk requested review of this revision.Mar 7 2019, 7:26 AM
kfunk added a comment.Mar 7 2019, 7:33 AM

By the way, also see: https://stackoverflow.com/a/5195913 wrt why it is dangerous.

sitter accepted this revision.Mar 7 2019, 10:17 AM

lgtm

This revision is now accepted and ready to land.Mar 7 2019, 10:17 AM
Closed by commit R572:1ac3decab112: tagme: Do not use git push --tags (authored by kfunk). · Explain WhyMar 7 2019, 10:23 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtagme.rb (4 lines)

Diff 53348

View Options

tagme.rb

Loading...