[sddm-theme/lock screen] Fix "unable to assign [undefined]" error
ClosedPublic

Authored by rooty on Mar 7 2019, 6:56 AM.

Details

Summary

This patch fixes the "Unable to assign [undefined] to QColor" and "Unable to assign [undefined] to int" errors that occur in UserDelegate.qml (188:9, 187:9) and Clock.qml (53:13, 52:13, 60:13, 59:13), visible in sddm-greeter's output.

It does so by resetting the label style to Normal (instead of undefined). Once Text.Normal is set, the outline color is set as transparent (but that doesn't matter since there's no outline to begin with).

Test Plan

Works the same, looks the same, no error in output.

Diff Detail

Repository
R120 Plasma Workspace
Branch
no-more-unabletoassign (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9268
Build 9286: arc lint + arc unit
rooty created this revision.Mar 7 2019, 6:56 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 7 2019, 6:56 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
rooty requested review of this revision.Mar 7 2019, 6:56 AM
rooty edited the test plan for this revision. (Show Details)Mar 7 2019, 6:56 AM
rooty added reviewers: VDG, Plasma.
rooty retitled this revision from [sddm-theme/lock screen] Fix "unable to assign [undefined] error to [sddm-theme/lock screen] Fix "unable to assign [undefined]" error.
rooty edited the summary of this revision. (Show Details)
broulik accepted this revision.Mar 7 2019, 7:56 AM
This revision is now accepted and ready to land.Mar 7 2019, 7:56 AM
This revision was automatically updated to reflect the committed changes.