Differential D19576

Add Team Drive create job feature.
ClosedPublic
Actions

Authored by barchiesi on Mar 7 2019, 12:04 AM.

Details

Reviewers
dvratil
Maniphest Tasks
T10521: [Drive] Implement Team Drives portion of the API
Commits
R477:86f53f91d6de: Add Team Drive create job feature.
Summary

Allow creating a new Team Drive through TeamdriveCreateJob.

Test Plan

TeamdriveCreateJobTest was added as a test case and the teamdrive example has been updated to allow creating Team Drives.

Diff Detail

Repository
R477 KGAPI Library
Lint
Lint Skipped
Unit
Unit Tests Skipped
barchiesi created this revision.Mar 7 2019, 12:04 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMar 7 2019, 12:04 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
dvratil requested changes to this revision.Mar 8 2019, 10:02 AM

One minor nitpick, otherwise looking good :) Thanks!

src/drive/teamdrivecreatejob.h
40

Could you make the request ID accessible through a getter, so it's possible to pair the job to a request in finished(Job*) slot?

This revision now requires changes to proceed.Mar 8 2019, 10:02 AM
barchiesi updated this revision to Diff 53435.Mar 8 2019, 1:25 PM

Added getter and updated test (not sure how useful).

dvratil accepted this revision.Mar 8 2019, 4:48 PM

Thanks!

This revision is now accepted and ready to land.Mar 8 2019, 4:48 PM
Closed by commit R477:86f53f91d6de: Add Team Drive create job feature. (authored by barchiesi, committed by dvratil). · Explain WhyMar 11 2019, 3:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 53326

View Options

autotests/CMakeLists.txt

Loading...
View Options

autotests/drive/data/teamdrive_create_request.txt

Loading...
View Options

autotests/drive/data/teamdrive_create_response.txt

Loading...
View Options

autotests/drive/teamdrivecreatejobtest.cpp

Loading...
View Options

examples/teamdrive/mainwindow.h

Loading...
View Options

examples/teamdrive/mainwindow.cpp

Loading...
View Options

examples/teamdrive/ui/main.ui

Loading...
View Options

src/drive/CMakeLists.txt

Loading...
View Options

src/drive/teamdrive.h

Loading...
View Options

src/drive/teamdrive.cpp

Loading...
View Options

src/drive/teamdrivecreatejob.h

Loading...
View Options

src/drive/teamdrivecreatejob.cpp

Loading...