Add Team Drive create job feature.
ClosedPublic

Authored by barchiesi on Mar 7 2019, 12:04 AM.

Details

Summary

Allow creating a new Team Drive through TeamdriveCreateJob.

Test Plan

TeamdriveCreateJobTest was added as a test case and the teamdrive example has been updated to allow creating Team Drives.

Diff Detail

Repository
R477 KGAPI Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
barchiesi created this revision.Mar 7 2019, 12:04 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMar 7 2019, 12:04 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
dvratil requested changes to this revision.Mar 8 2019, 10:02 AM

One minor nitpick, otherwise looking good :) Thanks!

src/drive/teamdrivecreatejob.h
41

Could you make the request ID accessible through a getter, so it's possible to pair the job to a request in finished(Job*) slot?

This revision now requires changes to proceed.Mar 8 2019, 10:02 AM
barchiesi updated this revision to Diff 53435.Mar 8 2019, 1:25 PM

Added getter and updated test (not sure how useful).

dvratil accepted this revision.Mar 8 2019, 4:48 PM

Thanks!

This revision is now accepted and ready to land.Mar 8 2019, 4:48 PM
This revision was automatically updated to reflect the committed changes.