Differential D19572

[kcolorschemeditor] Don't re-add existing tab
ClosedPublic
Actions

Authored by broulik on Mar 6 2019, 6:20 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R119:45f10322b8f3: [kcolorschemeditor] Don't re-add existing tab
Summary

This keeps it from unexpectedly changing tabs as you change any values.

BUG: 393282
FIXED-IN: 5.15.3

Test Plan

I tried to look into why Qt does it but I couldn't figure out why it happens.

tabWidget->currentIndex(); // is 3
tabWidget->addTab(m_inactiveTab, i18n("Inactive")); // returns 3
tabWidget->currentIndex(); // is suddenly 2?!

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mar 6 2019, 6:20 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 6 2019, 6:20 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Mar 6 2019, 6:20 PM
mart accepted this revision.Mar 8 2019, 9:13 AM
This revision is now accepted and ready to land.Mar 8 2019, 9:13 AM
Closed by commit R119:45f10322b8f3: [kcolorschemeditor] Don't re-add existing tab (authored by broulik). · Explain WhyMar 8 2019, 9:39 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcms/colors/scmeditordialog.cpp (14 lines)

Diff 53419

View Options

kcms/colors/scmeditordialog.cpp

Loading...