Follow kde hig for the search field
ClosedPublic

Authored by ognarb on Mar 5 2019, 10:06 PM.

Diff Detail

Repository
R125 KHelpCenter
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ognarb created this revision.Mar 5 2019, 10:06 PM
Restricted Application added a project: Documentation. · View Herald TranscriptMar 5 2019, 10:06 PM
Restricted Application added a subscriber: kde-doc-english. · View Herald Transcript
ognarb requested review of this revision.Mar 5 2019, 10:06 PM
ognarb updated this revision to Diff 53247.Mar 5 2019, 10:12 PM

Give focus to search field after search

ognarb edited the summary of this revision. (Show Details)Mar 5 2019, 10:15 PM
ognarb added reviewers: VDG, Documentation.
ognarb retitled this revision from Use kde hig for the search field to Follow kde hig for the search field.
ngraham accepted this revision as: VDG.Mar 5 2019, 11:01 PM

Before this is pushed, as I can't test right now: does the search start immediately? If it does, please check how Okular delays it slightly to allow users to type more characters without starting an "heavy" operation.

ognarb added a comment.EditedMar 5 2019, 11:28 PM

Before this is pushed, as I can't test right now: does the search start immediately? If it does, please check how Okular delays it slightly to allow users to type more characters without starting an "heavy" operation.

The search only start after clicking enter and when searching the search field is disabled, as it was previously. Should I change this behavior and add a small delay?

ltoscano accepted this revision.Mar 5 2019, 11:31 PM

Oh, right. Thanks.

This revision is now accepted and ready to land.Mar 5 2019, 11:31 PM
This revision was automatically updated to reflect the committed changes.

Oh, right. Thanks.

As a next patch in khelpcenter, I wanted to replace the khtml view with qtwebengine. By doing so, I think we could use an update css style sheet in the view (like this: http://docs.carlschwan.eu/stable5/en/extragear-base/kcontrol/wacomtablet/stylus.html#pen-button-settings) .

Before I start, do you think this is a good idea? Any tips? 😄

Oh, right. Thanks.

As a next patch in khelpcenter, I wanted to replace the khtml view with qtwebengine. By doing so, I think we could use an update css style sheet in the view (like this: http://docs.carlschwan.eu/stable5/en/extragear-base/kcontrol/wacomtablet/stylus.html#pen-button-settings) .

Before I start, do you think this is a good idea? Any tips? 😄

I'd prefer to keep a choice of the rendering part, so not qtwebengine-specific.

The problem right now is that the KHTMLPart also embeds a lot of other details that should be moved somewhere else, so that other rendering kparts can be plugged-in (the old kwebkitpart, or a new, still unwritten, basic QtTextDocument-based kpart.

I understand the need for updating the style, but maybe we could have a simpler theme that looks similar but it does not need the latest version of CSS.
Anyway, as long as there is no an hard-dependency on qtwebengine, I'm fine.

Oh, right. Thanks.

As a next patch in khelpcenter, I wanted to replace the khtml view with qtwebengine. By doing so, I think we could use an update css style sheet in the view (like this: http://docs.carlschwan.eu/stable5/en/extragear-base/kcontrol/wacomtablet/stylus.html#pen-button-settings) .

Before I start, do you think this is a good idea? Any tips? 😄

I'd prefer to keep a choice of the rendering part, so not qtwebengine-specific.

The problem right now is that the KHTMLPart also embeds a lot of other details that should be moved somewhere else, so that other rendering kparts can be plugged-in (the old kwebkitpart, or a new, still unwritten, basic QtTextDocument-based kpart.

I understand the need for updating the style, but maybe we could have a simpler theme that looks similar but it does not need the latest version of CSS.
Anyway, as long as there is no an hard-dependency on qtwebengine, I'm fine.

Ok I will try to implement a simpler css theme that work with ktml. ;)