[effects/screenshot] Set m_windowMode in screenshotWindowUnderCursor
ClosedPublic

Authored by broulik on Mar 5 2019, 8:26 PM.

Details

Summary

BUG: 374864
FIXED-IN: 5.15.3

Test Plan

Could also go into 5.12

Was the only obvious omission from screenshotForWindow which worked

  • Screenshot "window under cursor" now works in Spectacle
  • Screenshot "active window" still works

Thanks to @davidre in that bug report for pointing in the right direction

Diff Detail

Repository
R108 KWin
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Mar 5 2019, 8:26 PM
Restricted Application added a project: KWin. · View Herald TranscriptMar 5 2019, 8:26 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
broulik requested review of this revision.Mar 5 2019, 8:26 PM
broulik edited the test plan for this revision. (Show Details)
broulik added a subscriber: davidre.
ngraham added a subscriber: ngraham.Mar 5 2019, 9:11 PM

Works great for me!

zzag added a subscriber: zzag.Mar 5 2019, 9:55 PM

Hmm, looks like windowUnderCursor was left out in D3367. Anyway, this patch looks good to me.

If you mention a person in the commit message, please use real name, not nickname.

davidedmundson accepted this revision.Mar 5 2019, 9:58 PM
This revision is now accepted and ready to land.Mar 5 2019, 9:58 PM
This revision was automatically updated to reflect the committed changes.
wbauer added a subscriber: wbauer.Mar 13 2019, 9:09 AM

What about 5.12?
The problem exists there too, and this patch fixes it.