[sddm-theme/lock screen] Use default font size adjustments instead of hardcoded sizes
ClosedPublic

Authored by rooty on Mar 5 2019, 5:04 PM.

Details

Summary

Same result as D19433, except not hardcoded anymore (adjusts for the default font size the user sets).

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rooty created this revision.Mar 5 2019, 5:04 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 5 2019, 5:04 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
rooty requested review of this revision.Mar 5 2019, 5:04 PM
rooty edited the summary of this revision. (Show Details)Mar 5 2019, 5:06 PM
rooty added reviewers: VDG, Plasma, filipf, ngraham.
filipf accepted this revision as: filipf.Mar 5 2019, 5:09 PM
This revision is now accepted and ready to land.Mar 5 2019, 5:09 PM

Hmm, this means that when the user has customized the text size in their own user account, the text size will be different on the Login screen (which does not follow user settings) vs the lock and logout screens (which do). Looks like there's really no way around that unless we stay with sizes that are hardcoded in all three. Depends on which issue we want to have, I guess.

rooty added a comment.Mar 5 2019, 5:14 PM

Hmm, this means that when the user has customized the text size in their own user account, the text size will be different on the Login screen (which does not follow user settings) vs the lock and logout screens (which do). Looks like there's really no way around that unless we stay with sizes that are hardcoded in all three. Depends on which issue we want to have, I guess.

Actually the problem's even worse than that - there's no GUI geared toward modifying the sddm user settings at present, so we can't set the fonts, font smoothing, scaling or font size on the login screen.
This might be an avenue worth pursuing?

filipf added a comment.Mar 5 2019, 5:15 PM

Hmm, this means that when the user has customized the text size in their own user account, the text size will be different on the Login screen (which does not follow user settings) vs the lock and logout screens (which do). Looks like there's really no way around that unless we stay with sizes that are hardcoded in all three. Depends on which issue we want to have, I guess.

Our problem is really that the login screen doesn't respect the user's settings or at least can't be configured according to the admin user's liking. There's always going to be something off about SDDM unless the user uses KDE defaults. IMO the solution offered here is better than forcing people into having fontsizes they might not want to be seeing.

ngraham accepted this revision.Mar 5 2019, 5:22 PM

Yeah, you're probably right.

This revision was automatically updated to reflect the committed changes.