Send blur/background contrast in device pixels
ClosedPublic

Authored by davidedmundson on Mar 5 2019, 3:30 PM.

Details

Summary

A Qt app using Qt scaling will only know the position of windows and all
geometry in logical pixels. Kwin needs everything in device pixels.

This hasn't been a big issue till now as plasma on X doesn't opt in for
Qt scaling. For wayland everything is in the same sane coordinate space.

It can occur in some previews in systemsettings and at some point maybe plasma should use
Qt scaling on X

BUG: 404923

Test Plan

Task switcher now blurred the whole area.
Ran plamsa on X with plasma_use_qt_scaling. Kickoff was less corrupted.

Diff Detail

Repository
R278 KWindowSystem
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9197
Build 9215: arc lint + arc unit
davidedmundson created this revision.Mar 5 2019, 3:30 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 5 2019, 3:30 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Mar 5 2019, 3:30 PM
zzag added a subscriber: zzag.Mar 5 2019, 3:41 PM
zzag added inline comments.
src/platforms/xcb/kwindoweffects.cpp
266

should we floor or round?

davidedmundson added inline comments.Mar 5 2019, 4:39 PM
src/platforms/xcb/kwindoweffects.cpp
266

Our best option is to match QHighDpi::toNativePixels(QRect)
Which seems to floor

zzag accepted this revision.Mar 5 2019, 5:19 PM
This revision is now accepted and ready to land.Mar 5 2019, 5:19 PM
This revision was automatically updated to reflect the committed changes.