Differential D19538

ECMGeneratePkgConfigFile: make all vars dependent on ${prefix}
ClosedPublic
Actions

Authored by dfaure on Mar 5 2019, 10:49 AM.

Details

Reviewers

kossebau
apol
krop

Commits

R240:bb8c053d9d41: ECMGeneratePkgConfigFile: make all vars dependent on ${prefix}

Summary

Note that the first test had a comment "without optional arguments"
so I removed the INCLUDE_INSTALL_DIR variable to test what happens by
default. The other tests still pass an absolute path there (which is
unusual in practice, and breaks the idea of using ${prefix}).

Test Plan

ctest -R PkgConfig passes

Diff Detail

Repository

R240 Extra CMake Modules

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 9185
Build 9203: arc lint + arc unit

dfaure created this revision.Mar 5 2019, 10:49 AM

Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptMar 5 2019, 10:49 AM

dfaure requested review of this revision.Mar 5 2019, 10:49 AM

Harbormaster completed remote builds in B9185: Diff 53189.Mar 5 2019, 10:49 AM

apol accepted this revision.Mar 5 2019, 1:26 PM

This revision is now accepted and ready to land.Mar 5 2019, 1:26 PM

dfaure closed this revision.Mar 5 2019, 2:40 PM

Revision Contents
Changeset List

			Path	Packages
M			modules/ECMGeneratePkgConfigFile.cmake (10 lines)
M			tests/ECMGeneratePkgConfigFile/KF5CoreAddons.pc (11 lines)
M			tests/ECMGeneratePkgConfigFile/KF5CoreAddons2.pc (7 lines)
M			tests/ECMGeneratePkgConfigFile/KF5CoreAddons3.pc (7 lines)
M			tests/ECMGeneratePkgConfigFile/run_test.cmake.config (1 line)