compile without foreach
Details
Details
Diff Detail
Diff Detail
- Repository
- R249 KI18n
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| CMakeLists.txt | ||
|---|---|---|
| 74 | Removing this line is doesn't allow build to succeed, I had to comment this line to make it successful. My build log: I am using build_kf5.sh to build the framework | |
| CMakeLists.txt | ||
|---|---|---|
| 74 | Sorry for the typo, I can't edit the comment it seems. I mean to say, having this line is causing the build to fail. | |
Comment Actions
I pushed a fix, please test: https://commits.kde.org/ki18n/927fd6c20a7e0acfe87353abb93dcb066d1d0713
Laurent: this was Android-specific code, not compiled on Linux. I suggest grepping for Q_FOREACH/foreach after it compiles.
Comment Actions
Hi. By pure chance I saw that commit bypassing, but am wondering: QString::replace() is a non-const method with all of the overloads, am I missing something?
Comment Actions
Ah, seems I missed this was Android-specific code, and CI confirms what I had been thinking before, by failing the build for Android. Okay, nothing missed here on my side it seems, so moving out again :)
Comment Actions
It seemed to me you were actively working on related stuff, and I was just too quickly curious without access to a build setup, so did not want to interfere even more :)