- Create malformed syntax highlighting file with missing end tags
- Place it in ~/.local/share/katepart5/syntax/
- Open Kate with file which uses that syntax highlighting
Details
Diff Detail
- Repository
- R39 KTextEditor
- Branch
- malformed
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 9211 Build 9229: arc lint + arc unit
In principle ok, but I would like to have the m_properties.resi.... code in that if shared.
We already have that, just a few lines above.
You just need to move the computation of the auto definitions = definition().includedDefinitions(); a few lines up, you can just call that on the passed def.
And btw., thanks for taking care of that crash, it's ugly to crash for such things. My fault, did never test that :/
Hmm, I just thought that might be correct, but doesn't that kill highlighting for all definitions that include none?
If forgot that includedDefinitions() doesn't include itself, that check makes no sense ;=)
I think we are missing some check at the end if we had no formats at all.
Sorry that I was confused, but I just have seen your check of definitions.isEmpty() and thought that would be the right one.
That looks reasonable, if the definition doesn't have any included ones + no own formats it is likely to be broken ;=)