Differential D19530

Avoid fractionals in GridDelegate sizes and alignments
ClosedPublic
Actions

Authored by davidedmundson on Mar 4 2019, 10:10 PM.

Details

Reviewers
ngraham
rooty
Group Reviewers
Plasma
Commits
R296:715ce3c20837: Avoid fractionals in GridDelegate sizes and alignments
Summary

The thumbnail object within the Delegate is offset by float amounts

Test Plan

TBH it all looks the same to me.
Gammray no longer has float values for the inner Thumbnail offset

Diff Detail

Repository
R296 KDeclarative
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Mar 4 2019, 10:10 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 4 2019, 10:10 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Mar 4 2019, 10:10 PM
filipf added a subscriber: filipf.Mar 4 2019, 10:18 PM

David this really does fix it! Previews are nice and sharp everywhere now.

See before:

And after:

Notice how e.g. the 4 squares are sharp now?

ngraham accepted this revision.Mar 5 2019, 1:05 AM
ngraham added a subscriber: ngraham.

Very nice fix.

This revision is now accepted and ready to land.Mar 5 2019, 1:05 AM
rooty accepted this revision.EditedMar 5 2019, 3:04 AM
rooty added a subscriber: rooty.

A lot easier on the eyes now, really nice fix

This'll be landing in 5.16?

filipf added a comment.Mar 5 2019, 9:16 AM
In D19530#424922, @rooty wrote:

A lot easier on the eyes now, really nice fix

This'll be landing in 5.16?

KF 5.57 as far as I can tell.

Closed by commit R296:715ce3c20837: Avoid fractionals in GridDelegate sizes and alignments (authored by davidedmundson). · Explain WhyMar 5 2019, 1:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 53203

View Options

src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

Loading...