Differential D19527

Remove find modules provided by ECM
ClosedPublic
Actions

Authored by vkrause on Mar 4 2019, 8:42 PM.

Details

Reviewers

Commits

R239:48d9c36738d0: Remove find modules provided by ECM

Summary

This matters specifically here as kdelibs4support installs them and
adds them to the module search path, which can interfere with the
newer ones provided by ECM (see e.g. D18943).

Diff Detail

Repository

R239 KDELibs4Support

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

vkrause created this revision.Mar 4 2019, 8:42 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptMar 4 2019, 8:42 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

vkrause requested review of this revision.Mar 4 2019, 8:42 PM

Harbormaster completed remote builds in B9168: Diff 53163.Mar 4 2019, 8:42 PM

I doubt a bit here because they work slightly different, but being part of kdelibs4support it's probably a matter of just using the right ones.

This revision is now accepted and ready to land.Mar 5 2019, 1:35 AM

FindSasl2.cmake & FindPulseAudio.cmake also exist in both repo.

Also remove FindPulseAudio. The Sasl2 one misses compatibility variables in ECM it seems.

Harbormaster completed remote builds in B9202: Diff 53218.Mar 5 2019, 4:59 PM

Closed by commit R239:48d9c36738d0: Remove find modules provided by ECM (authored by vkrause). · Explain WhyMar 31 2019, 8:55 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		cmake/modules/CMakeLists.txt (4 lines)
D	M	cmake/modules/FindFontconfig.cmake (50 lines)
D	M	cmake/modules/FindGLIB2.cmake (52 lines)
D	M	cmake/modules/FindPulseAudio.cmake (71 lines)
D	M	cmake/modules/FindUDev.cmake (37 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	53163	abbb369		Mar 4 2019, 8:42 PM	★	★
Diff 2	53218	abbb369	Also remove FindPulseAudio. The Sasl2 one misses compatibility variables in ECM…	Mar 5 2019, 4:59 PM	★	★
Diff 3	55113	ff85d52	R239:48d9c36738d0efbc257ab0eac4c03650b74eb95d	Mar 31 2019, 8:54 AM	★	★