Fix recangle-selection help-text positioning
ClosedPublic

Authored by nrother on Mar 4 2019, 2:57 PM.

Details

Summary

BUG: 361053

When taking a screenshot with the rectangle selection tool in spectacle,
the overlaid help-text is put in the center of the entire desktop,
instead of the center of a single display. This can cause readability
issues when it is placed on the bezel of two physical displays.
This patch horizontally centers the help-text overlay on the primary display.
This affects both the "Click anywhere to start" dialogue and the hotkey help-text.

Test Plan

Before:


After:


Diff Detail

Repository
R166 Spectacle
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nrother requested review of this revision.Mar 4 2019, 2:57 PM
nrother created this revision.
ngraham accepted this revision.Mar 4 2019, 3:22 PM
ngraham added a subscriber: ngraham.

Thanks, this is perfect!

Can you provide your full name and email address so I can land this patch with correct authorship information?

This revision is now accepted and ready to land.Mar 4 2019, 3:22 PM
abetts added a subscriber: abetts.Mar 4 2019, 3:23 PM

Love it! +1

Thanks, this is perfect!

Can you provide your full name and email address so I can land this patch with correct authorship information?

Name: Nils Rother

E-Mail: Nilsrother123@gmail.com

I had assumed that Phabricator makes this info available to reviewers, this is my first time working with it.
Thanks!

This revision was automatically updated to reflect the committed changes.

I had assumed that Phabricator makes this info available to reviewers

Only when you use the arc command-line tool to submit the patch, I'm afraid. For more information, see https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches

Great first patch, by the way. People are really going to appreciate this, and I'll be mentioning it on the next installment of https://pointieststick.com/category/usability-productivity/

For your next patch, would you like to try one of these?

Only when you use the arc command-line tool to submit the patch, I'm afraid. For more information, see https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches

I see. I'll have a look at getting that set up then, thanks!

Great first patch, by the way. People are really going to appreciate this, and I'll be mentioning it on the next installment of https://pointieststick.com/category/usability-productivity/

For your next patch, would you like to try one of these?

Very Happy to hear that! I'll definitely look at contributing more in the future; It feels great to help out, even if it's just small fixes!

Yay! Welcome aboard! :)