Fix ibeam and underline cursor rendering
ClosedPublic

Authored by wbauer on Mar 4 2019, 2:10 PM.

Details

Summary

Since anti-aliasing was enabled in the painter, coordinates need to
be shifted half a pixel so that they align with the pixel grid,
otherwise the result gets "blurred" due to the anti-aliasing.
And as parts of the blurred shape leak outside the cursor rectangle,
this also leaves artifacts when the cursor moves or blinks as these
parts are not cleared.

This is basically the same as commit
e7085310d6d594823d0ed491fa8bdbd99dec4932 for the
standard block cursor.

BUG: 402589

Test Plan
  • Switch cursor shape to "I-Beam" or "Underline" in the "Advanced"

profile settings

The cursors are a single line again now, before they were blurred by
anti-aliasing.

Screenshots:
Before:


After:


Also, there are no more artifacts when the cursor is moved or
cursor blinking is enabled.

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
wbauer created this revision.Mar 4 2019, 2:10 PM
Restricted Application added a subscriber: konsole-devel. · View Herald TranscriptMar 4 2019, 2:10 PM
wbauer requested review of this revision.Mar 4 2019, 2:10 PM
wbauer edited the summary of this revision. (Show Details)
wbauer edited the test plan for this revision. (Show Details)Mar 4 2019, 2:53 PM
hindenburg edited the summary of this revision. (Show Details)Mar 4 2019, 2:59 PM
hindenburg edited the test plan for this revision. (Show Details)
hindenburg added a subscriber: hindenburg.

Thanks, I'm looking at - if you are using arc, can you set it up to add your name/email to the commit message? Not a show stopper as I can fix when I commit

wbauer added a comment.Mar 4 2019, 3:17 PM

Thanks, I'm looking at - if you are using arc, can you set it up to add your name/email to the commit message? Not a show stopper as I can fix when I commit

Sorry, I don't have arc installed. I always use git directly to push (and the webinterface to upload patches for review)...

That's OK, can I get your email address so I can attribute the patch correctly?

That's OK, can I get your email address so I can attribute the patch correctly?

wbauer@tmo.at, but I could also push it myself if you want.

wbauer edited the summary of this revision. (Show Details)Mar 5 2019, 12:35 PM
hindenburg accepted this revision.Mar 5 2019, 2:36 PM

ok thanks

This revision is now accepted and ready to land.Mar 5 2019, 2:36 PM
This revision was automatically updated to reflect the committed changes.