This may not needed because the information is already shown as part of the
inputMode label, on the other hand is that information there somehow misplaced.
Details
- Reviewers
cullmann - Group Reviewers
KTextEditor - Commits
- R39:186b4858818c: KateStatusBar: Show lock icon on modified label when in read-only mode
You see the little lock bottom left?
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
You will notice that not all possible switch cases are checked. Should you like this patch in general I will review this depending on D19511.
I think the lock icon won't hurt.
For the implementation: isn't it enough to watch for the readWriteChanged(...) signal of the document and trigger the modifiedChanged() changed there?
Semi-relatedly: can we make this little bottom-left corner icon not not have a hover effect if it's not clickable, and have a tooltip when you hover over it so you can figure out what it means? It appeared recently and I found myself very confused by it due to those issues.
Semi-relatedly: can we make this little bottom-left corner icon not not have a hover effect if it's not clickable, and have a tooltip when you hover over it so you can figure out what it means? It appeared recently and I found myself very confused by it due to those issues.
I agree, its currently a little odd. I plan to show some inview hint like done in goto bar and to add a save action, when modified. Objections to this? Tool Tips are bad, in most cases, and here especially .
I am not sure if tooltips are that great in the status bar.
You often hover over that during work and they disturb you then.
Regarding icon, tooltip and save action, see also https://phabricator.kde.org/D17730#392331