[Logout screen] Fix label opacity failing
ClosedPublic

Authored by filipf on Mar 4 2019, 1:46 PM.

Details

Summary

Due to Qt bug: https://bugreports.qt.io/browse/QTBUG-70138 (KDE bug: https://bugs.kde.org/show_bug.cgi?id=401644) we have label opacity utterly failing when the logout screen is superimposed over a bright background. Even though QtRendering is the inferior renderer, this patch uses it as a workaround for the aforementioned bug since ugly (if it ever would be) text is better than (almost) no text.

Test Plan

Before:

After:

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9260
Build 9278: arc lint + arc unit
filipf created this revision.Mar 4 2019, 1:46 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 4 2019, 1:46 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Mar 4 2019, 1:46 PM
filipf edited the summary of this revision. (Show Details)Mar 4 2019, 1:48 PM
filipf edited the test plan for this revision. (Show Details)
filipf added reviewers: Plasma, ngraham.
rooty accepted this revision.Mar 4 2019, 2:35 PM
This revision is now accepted and ready to land.Mar 4 2019, 2:35 PM
rooty added a comment.Mar 4 2019, 2:36 PM

This is a neat workaround as discussed in D19479

ngraham accepted this revision.Mar 5 2019, 4:11 PM
filipf updated this revision to Diff 53316.Mar 6 2019, 9:30 PM

Use QtRendering only when opacity is not 1

filipf added a comment.Mar 6 2019, 9:30 PM

@ngraham to further minimize the use of QtRendering I've added code so that it's used only when opacity is not 1. Is that okay?

ngraham added inline comments.Mar 6 2019, 9:33 PM
lookandfeel/contents/logout/LogoutButton.qml
34

Add a space between = and 1

filipf updated this revision to Diff 53317.Mar 6 2019, 9:34 PM

Add space between = and 1

filipf marked an inline comment as done.Mar 6 2019, 9:34 PM
ngraham accepted this revision.Mar 6 2019, 9:35 PM
This revision was automatically updated to reflect the committed changes.