Details
- Reviewers
vkrause - Commits
- R849:546879d35838: Fix wrong include
Diff Detail
- Repository
- R849 User Feedback Collection Framework
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Does this break the build for you? Since this header is technically from a different library, the use of the angle brackets doesn't seem wrong to me...
Yes, it does, unfortunately.
The problem here is in search location. If the framework is not installed as a system dependency (i.e. headers aren't located somewhere in standard include directory), abstractdatasource.h cannot be found. Using regular quotes also makes sense, because styleinfosource.h and abstractdatasource.h are in the same directory.
I can't seem to reproduce this here, nor can the CI apparently. Also, those two header files are in different folders here...
Hm, are you using a different build system by any chance?
I use CMake, like this:
cd kuserfeedback mkdir build && cd build cmake .. -DCMAKE_INSTALL_PREFIX:PATH="some_custom_path" -DCMAKE_BUILD_TYPE=Debug make -sj12 make install
Then I build my app with qmake. The framework installed here: app_dir_path/3rdparty/kuserfeedback/ . After installation all headers are in the same directory.
Oh, so this is a build error *in the application*, not in kuserfeedback itself, when using qmake. Now that makes a lot more sense and I understand the problem and the fix :)
If you don't have commit rights yet, I can land this for you, but I'd need an email address to properly attribute it.
I guess, I don't, I've never contributed to KDE before. It would be nice if you could merge this commit, thank you. My email is vitaly.fanaskov (at) qt.io, name is Vitaly Fanaskov.