Quick Open should filter on file path
ClosedPublic

Authored by michalhumpula on Mar 2 2019, 4:03 PM.

Details

Reviewers
cullmann
Group Reviewers
Kate
Summary

Please consider the Quick Open to be able to filter against whole file path not just file name. It should be possible to filter out files with rules like addons*index.

Diff Detail

Repository
R40 Kate
Lint
Lint Skipped
Unit
Unit Tests Skipped
michalhumpula created this revision.Mar 2 2019, 4:03 PM
Restricted Application added a project: Kate. · View Herald TranscriptMar 2 2019, 4:03 PM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
michalhumpula requested review of this revision.Mar 2 2019, 4:03 PM

In principle that sounds reasonable.
Actually, would it be possible to make that configurable, e.g. in the context menu there for people that prefer only filename matching?

This was the original behavior before quick open refactor, but I'm ok with making it changeable. In theory it could be easily extended with for example Levenshtein distance matching. Not sure about putting it in context menu (which one?). If some people would prefer one or the other I guess they would want to do it globally for all kate sessions. Wouldn't it be better to put it in settings->appearance then?

I have no problem with having that in the settings dialog.
Otherwise I would just have put it in the context menu of the search (or given that some small icon with a menu.

cullmann requested changes to this revision.Mar 4 2019, 6:29 PM

Add an option and we can merge that ;=)
Thanks.

This revision now requires changes to proceed.Mar 4 2019, 6:29 PM

@cullmann What's the reason for wanting an option? Is it too slow for big repos such as e.g. the linux kernel git?

Depending on your folder naming, it could make it not that useful ;=)
(because your folder already contains a lot of names you want to search for, like e.g. your toplevel folder ist kate, searching for kate will yield all files)

Sorry it took so long, I've had a busy week. I've added to general configuration tab the option to switch the quick open match mode. I don't like the implementation though. The thing is quite scattered all over the place.

cullmann accepted this revision.Mar 9 2019, 4:05 PM

Yeah, the config stuff in the kate application is not that optimal.
Still, lets have this in now, thanks!

This revision is now accepted and ready to land.Mar 9 2019, 4:05 PM
michalhumpula closed this revision.Mar 9 2019, 5:12 PM

Could you use a QComboBox in a separate patch?

kate/kateconfigdialog.h
87

Btw, I see this only now: this should be a QComboBox, right?