[Login, Lock, and Logout Screen] Make the avatar background circle more subtle
ClosedPublic

Authored by filipf on Mar 2 2019, 3:53 PM.

Details

Summary

Added in D16879, the background circle was designed to work on a blurless login screen. Since we have abandoned that idea, it's good to adjust it to our present needs. This patch lowers the opacity of the circle and removes the double border it created.

Test Plan

Before:

After:

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
filipf created this revision.Mar 2 2019, 3:53 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 2 2019, 3:53 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Mar 2 2019, 3:53 PM
filipf edited the test plan for this revision. (Show Details)Mar 2 2019, 3:54 PM
filipf added reviewers: ngraham, VDG, Plasma.
filipf edited the summary of this revision. (Show Details)
filipf added a reviewer: rooty.
filipf added a comment.Mar 2 2019, 4:20 PM

There's a little bit of fringing around the white border so I can subtract 2 from the width?

Left is before, right after. Doesn't quite solve it, but is a bit better.

ngraham accepted this revision.Mar 2 2019, 9:05 PM

This is fine. It makes it even more important that we make the current user's avatar bigger though. :)

This revision is now accepted and ready to land.Mar 2 2019, 9:05 PM

...And now that that's landed, I think this can too.

...And now that that's landed, I think this can too.

I would now wait until after D19479 so that we don't necessarily have dark and light circles. I would adjust this patch so both circles would look harmonious.

Now that the other patch is done, I come offering 2 solutions.

Solution 1: Mimic the action button circles' appearance

Solution 2: Current diff

rooty added a comment.Mar 8 2019, 11:37 AM

i vote for no 2 / current diff

rooty accepted this revision.Mar 8 2019, 12:46 PM

There doesn't seem to be anything else to be done here

filipf updated this revision to Diff 53434.Mar 8 2019, 12:56 PM

Subtract 2 from width so we don't get fringing

ngraham accepted this revision.Mar 8 2019, 2:53 PM
This revision was automatically updated to reflect the committed changes.