[sddm-theme] Update login screen preview image
ClosedPublic

Authored by rooty on Mar 2 2019, 12:04 PM.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rooty created this revision.Mar 2 2019, 12:04 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 2 2019, 12:04 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
rooty requested review of this revision.Mar 2 2019, 12:04 PM

Good work, but let's wait a bit with this since D19214 hasn't landed yet. I was also thinking of tweaking the background circle behind the user avatar.

filipf requested changes to this revision.Mar 8 2019, 9:42 PM
This revision now requires changes to proceed.Mar 8 2019, 9:42 PM
rooty updated this revision to Diff 53567.Mar 10 2019, 6:50 AM

Update preview to reflect latest theme version

rooty updated this revision to Diff 53570.Mar 10 2019, 7:11 AM

Make Katie uppercase

rooty edited the test plan for this revision. (Show Details)Mar 11 2019, 3:16 AM

I do believe that this is the very last patch for T10325: 5.16 Login screen improvements. :)

rooty added a comment.Mar 17 2019, 7:51 AM

I do believe that this is the very last patch for T10325: 5.16 Login screen improvements. :)

There is one last thing we might want to do for the login and lock screens - make them slightly more centered, vertically

before:


after:

If not, then this actually is the last patch (and it's up to date and landable too) :D

ngraham accepted this revision.Mar 17 2019, 8:51 AM

Seems like a nice-to-have, not a must-have. :) Is there a patch for it?

rooty added a comment.Mar 17 2019, 8:52 AM

I'll post one

Ping. :) Would be nice to get T10325 closed out.

rooty added a comment.Mar 20 2019, 6:22 AM

Sure thing
Sorry it's been taking so long, I've been having the hardest time getting virtualbox to work...

Sorry it's been taking so long, I've been having the hardest time getting virtualbox to work...

FWIW, you can run qmlscene Main.qml inside the

plasma-workspace/sddm-theme directly

It'll load the data from the testdata folder which makes development and custom screenshots much easier.

rooty added a comment.Mar 20 2019, 3:26 PM

I actually tried that but it doesn't recognize theme.conf so there's no wallpaper (it's all white)
I'm trying to take a screenshot from outside X but seeing as I'm new to this it's not making it easy

rooty updated this revision to Diff 54418.Mar 20 2019, 3:41 PM

Update preview image

rooty added a comment.Mar 20 2019, 3:42 PM

Okay so, scrot and xwd kinda drove me nuts, so I decided to open up sddm-greeter, cut off its titlebar, hide the panel and it looks identical to the login screen so :D Voila

GB_2 added a subscriber: GB_2.Mar 20 2019, 3:50 PM

The file size is quite big (you can change the compression in Spectacle) and I think the resolution should be 1920x1080.
Please also change the user images to the colorful Konqi and Katie ones.

rooty updated this revision to Diff 54421.Mar 20 2019, 3:51 PM

Compress image

rooty added a comment.EditedMar 20 2019, 3:56 PM
In D19469#435175, @GB_2 wrote:

The file size is quite big (you can change the compression in Spectacle) and I think the resolution should be 1920x1080.
Please also change the user images to the colorful Konqi and Katie ones.

But they're uglier? :D
And also - not present in the before image

GB_2 added a comment.Mar 20 2019, 3:57 PM
In D19469#435175, @GB_2 wrote:

The file size is quite big (you can change the compression in Spectacle) and I think the resolution should be 1920x1080.
Please also change the user images to the colorful Konqi and Katie ones.

But they're uglier? :D

I think they look nice and we've been using them in other previews and release announcements too.

rooty added a comment.Mar 20 2019, 3:58 PM
In D19469#435184, @GB_2 wrote:
In D19469#435175, @GB_2 wrote:

The file size is quite big (you can change the compression in Spectacle) and I think the resolution should be 1920x1080.
Please also change the user images to the colorful Konqi and Katie ones.

But they're uglier? :D

I think they look nice and we've been using them in other previews and release announcements too.

I beg to differ, but I'll change them if we've been using them in other places

GB_2 added a comment.Mar 20 2019, 4:01 PM

BTW, it's still not 1920x1080.

rooty added a comment.EditedMar 20 2019, 4:01 PM
In D19469#435215, @GB_2 wrote:

BTW, it's still not 1920x1080.

Noted. (Why is that relevant though?)

rooty added a comment.Mar 20 2019, 4:04 PM

This is the Konqi avatar I have available in SySe. It renders as fairly blurry / lower quality than the one I opted for originally - are you sure you want to use this?

GB_2 added a comment.Mar 20 2019, 4:05 PM
In D19469#435215, @GB_2 wrote:

BTW, it's still not 1920x1080.

Noted. (Why is that relevant though?)

Much more common resolution and also used for other images and previews.

GB_2 added a comment.Mar 20 2019, 4:09 PM

This is the Konqi avatar I have available in SySe. It renders as fairly blurry / lower quality than the one I opted for originally - are you sure you want to use this?

Hmm, I don't think this should happen, but then I'd just use the default user image.

rooty updated this revision to Diff 54424.Mar 20 2019, 4:15 PM

Use color avatars and 16:9 aspect ratio

rooty added a comment.Mar 20 2019, 4:18 PM

I'll be retaking this shortly - it says Openbox instead of Plasma (sorry) and yeah I'll be replacing the avatars
The blurry thing - don't look at me (or flipwise and me) because we're about as certain as a person can get that it's not sddm's (or the theme's) fault

rooty updated this revision to Diff 54427.Mar 20 2019, 4:35 PM

Use correct Desktop Sesion setting and use Konqi and Katie mascot avatars

rooty updated this revision to Diff 54430.Mar 20 2019, 4:39 PM

Deselect password field

ngraham accepted this revision.Mar 20 2019, 4:44 PM
filipf accepted this revision.Mar 20 2019, 5:14 PM

Beautiful.

This revision is now accepted and ready to land.Mar 20 2019, 5:14 PM
This revision was automatically updated to reflect the committed changes.