[sddm-theme/lock screen] Remove username shadow and show clock shadow only when unfocused
ClosedPublic

Authored by rooty on Mar 2 2019, 11:59 AM.

Details

Summary

This patch removes the shadow from the usernames on the login and lock screens. It also restricts the clock shadow to just the opaque (unfocused) versions of each screen.

Test Plan

Diff Detail

Repository
R120 Plasma Workspace
Branch
shadows-only-when-inactive (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9083
Build 9101: arc lint + arc unit
rooty created this revision.Mar 2 2019, 11:59 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 2 2019, 11:59 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
rooty requested review of this revision.Mar 2 2019, 11:59 AM
rooty retitled this revision from [sddm-theme/lock screen] Remove username shadow and show clock shadow only when opaque to [sddm-theme/lock screen] Remove username shadow and show clock shadow only when unfocused.Mar 2 2019, 12:00 PM
rooty edited the summary of this revision. (Show Details)
rooty edited the test plan for this revision. (Show Details)
rooty added reviewers: VDG, ngraham.
ngraham requested changes to this revision.Mar 2 2019, 12:25 PM

Won't the outlines get drawn when blurred if software rendering is in use?

This revision now requires changes to proceed.Mar 2 2019, 12:25 PM
rooty updated this revision to Diff 52976.Mar 2 2019, 1:19 PM

Disable shadows with softwareRendering enabled

rooty added a comment.EditedMar 2 2019, 1:20 PM

Won't the outlines get drawn when blurred if software rendering is in use?

I can't get any blur with software rendering though?
Another problem too - forcing software rendering leaves the username with an outline, but the action buttons without any shadow or outline (and no blur)

EDIT: The outline seems to work though, with software rendering enabled

except that it's really faint so I'd recommend using styleColor: "black" instead

rooty updated this revision to Diff 52978.Mar 2 2019, 1:22 PM

Correct typographical error

rooty added a comment.Mar 3 2019, 7:29 PM

Considering that there's an outline around the clock and the username now as a fallback option, should we add one to the action buttons too?

filipf added a subscriber: filipf.Mar 4 2019, 10:36 PM

Considering that there's an outline around the clock and the username now as a fallback option, should we add one to the action buttons too?

I think we only need an outline around the clock since the rest only shows up with blur?

But if blur fails with software rendering, then I think we need outlines for all the labels.

rooty added a comment.Mar 5 2019, 5:28 AM

Considering that there's an outline around the clock and the username now as a fallback option, should we add one to the action buttons too?

I think we only need an outline around the clock since the rest only shows up with blur?

But if blur fails with software rendering, then I think we need outlines for all the labels.

Yes, sorry for not mentioning that - I didn't see any blur with software rendering and the labels didn't have outlines.
I've been using QT_QUICK_BACKEND=software.

It looks pretty bad, even with outlines:

Maybe we should implement some kind of crude substitute for the wallpaperfader blur effect and add more contrast to the buttons (icons and labels) while we're at it, so that the software rendering version looks good too.

filipf added a comment.Mar 5 2019, 9:09 AM

Considering that there's an outline around the clock and the username now as a fallback option, should we add one to the action buttons too?

I think we only need an outline around the clock since the rest only shows up with blur?

But if blur fails with software rendering, then I think we need outlines for all the labels.

Yes, sorry for not mentioning that - I didn't see any blur with software rendering and the labels didn't have outlines.
I've been using QT_QUICK_BACKEND=software.

It looks pretty bad, even with outlines:

Maybe we should implement some kind of crude substitute for the wallpaperfader blur effect and add more contrast to the buttons (icons and labels) while we're at it, so that the software rendering version looks good too.

I'd suggest only to make the tool button frames visible (for stuff like keyboard layout etc.) and just give an outline to rest of the textual elements. I wouldn't bother too much with icons.

rooty updated this revision to Diff 53201.Mar 5 2019, 12:32 PM

Fix trailing whitespace

rooty added a comment.Mar 8 2019, 2:21 AM

The last holdout :D

rooty updated this revision to Diff 53402.Mar 8 2019, 2:49 AM

Rebase

rooty updated this revision to Diff 53451.Mar 8 2019, 3:28 PM

Refresh

rooty updated this revision to Diff 53452.Mar 8 2019, 3:29 PM

Rebase

rooty added a reviewer: filipf.Mar 8 2019, 3:31 PM
filipf accepted this revision.Mar 8 2019, 9:01 PM

Everything appears to be in order.

ngraham accepted this revision.Mar 8 2019, 9:22 PM

All good!

This revision is now accepted and ready to land.Mar 8 2019, 9:22 PM
This revision was automatically updated to reflect the committed changes.