[powerdevil] Correct labels
ClosedPublic

Authored by rooty on Mar 2 2019, 5:56 AM.

Details

Summary

This patch corrects the grammar in certain labels and adjusts others so they would conform to the KDE HIG.

Diff Detail

Repository
R122 Powerdevil
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rooty created this revision.Mar 2 2019, 5:56 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 2 2019, 5:56 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
rooty requested review of this revision.Mar 2 2019, 5:56 AM
rooty added a comment.Mar 2 2019, 5:56 AM

Should "Act like" be replaced with "Behave as?"

rooty edited the summary of this revision. (Show Details)

Should "Act like" be replaced with "Behave as?"

Is the control associated with this string actually used anywhere? I can't even find it.

kcmodule/activities/activityWidget.ui
72

While we're touching this, I think "Never turn off the screen" would sound more natural here.

rooty updated this revision to Diff 52958.Mar 2 2019, 12:14 PM
rooty marked an inline comment as done.

Shut down --> turn off

rooty added a comment.Mar 2 2019, 12:18 PM

I wonder if people would notice if it ended in a preposition (ironically "Never turn the screen off" sounds nicer to me)

kcmodule/activities/activityWidget.ui
72

Haha I had the idea to use turn off too, because you don't really ever "shut down" a screen

ngraham added inline comments.Mar 2 2019, 12:26 PM
kcmodule/activities/activityWidget.ui
72

Eh, let's make the English teachers happy. :)

rooty marked 2 inline comments as done.Mar 3 2019, 11:26 AM
rooty added inline comments.
kcmodule/activities/activityWidget.ui
72

Now let's only hope they'll switch to Plasma :D

rooty marked 2 inline comments as done.Mar 3 2019, 11:26 AM
ngraham accepted this revision.Mar 3 2019, 2:42 PM
This revision is now accepted and ready to land.Mar 3 2019, 2:42 PM
This revision was automatically updated to reflect the committed changes.