Fix errors in kirigami example files
ClosedPublic

Authored by ognarb on Mar 1 2019, 8:18 PM.

Details

Summary

Remove deprecation, fix anchors in RowLayout and remove trailing space

Done:

  • Sidebar.qml
  • MultipleColumnsGallery.qml
  • FixedSidebar.qml
  • AbstractApplicationWindow.qml // fixed crash but still very buggy
Test Plan

Using KWin transparency effect when moving windows, no pixel change found. Opening example files with qmlscene from konsole, only 4 error message left (before was more than 20)

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ognarb created this revision.Mar 1 2019, 8:18 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptMar 1 2019, 8:18 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ognarb requested review of this revision.Mar 1 2019, 8:18 PM
ognarb updated this revision to Diff 52927.Mar 1 2019, 9:45 PM

More fix

ognarb retitled this revision from WIP: Fix errors in kirigami example files to Fix errors in kirigami example files.Mar 1 2019, 9:48 PM
ognarb edited the summary of this revision. (Show Details)
ognarb added a reviewer: Kirigami.
apol added a subscriber: apol.Mar 4 2019, 1:51 AM

Others look good to me.

examples/simpleexamples/AbstractApplicationWindow.qml
105

Why's that?

ognarb added inline comments.Mar 8 2019, 1:48 PM
examples/simpleexamples/AbstractApplicationWindow.qml
105

Without I get the errror: TypeError: Property 'goBack' of object QQuickStackView_QML_91(0x55ea59443ee0) is not a function

mart added a subscriber: mart.Mar 17 2019, 4:37 PM
mart added inline comments.
examples/simpleexamples/AbstractApplicationWindow.qml
105

yeah, i think it's actually a kirigmai bug, let's not do it in the examples

an you report it to bugzilla?

ognarb updated this revision to Diff 54124.Mar 17 2019, 6:08 PM

Remove goBack funtion, and I repported the bug https://bugs.kde.org/show_bug.cgi?id=405571 :)

ognarb marked 3 inline comments as done.Mar 17 2019, 6:08 PM
mart accepted this revision.Mar 19 2019, 11:35 AM
This revision is now accepted and ready to land.Mar 19 2019, 11:35 AM
This revision was automatically updated to reflect the committed changes.