Differential D19453

Fix repository deletion warning
ClosedPublic
Actions

Authored by vkrause on Mar 1 2019, 8:08 PM.

Details

Reviewers
cullmann
dhaumann
Commits
R216:29e081b94b84: Fix repository deletion warning
Summary

Since 6166da75 the invalid/default Definition has a name ("None"), so
this check also triggers on that one, all the time. Instead check the
definition file name, that doesn't exist for an invalid Definition.

See also D19432, which triggered this.

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Mar 1 2019, 8:08 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptMar 1 2019, 8:08 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
vkrause requested review of this revision.Mar 1 2019, 8:08 PM
cullmann accepted this revision.Mar 1 2019, 9:15 PM
cullmann added a subscriber: cullmann.

Good catch :)

This revision is now accepted and ready to land.Mar 1 2019, 9:15 PM
kossebau added a subscriber: kossebau.Mar 1 2019, 9:17 PM

I can confirm this results in the warnings about Repository got deleted while a highlighter is still active! no longer being shown when using D19432.

Also no issues seen in Kate.

But not enough understanding of this code to comment whether this is a good fix.

dhaumann accepted this revision.Mar 1 2019, 9:38 PM
Closed by commit R216:29e081b94b84: Fix repository deletion warning (authored by vkrause). · Explain WhyMar 2 2019, 10:25 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/lib/abstracthighlighter.cpp (2 lines)

Diff 52943

View Options

src/lib/abstracthighlighter.cpp

Loading...