Define shortcuts for Find actions also for konsolepart
ClosedPublic

Authored by nicolasfella on Mar 1 2019, 7:11 PM.

Details

Summary

The find action in Yakuake (and other konsolepart users) is missing
a shortcut. This is because the shortcut is only defined for Konsole
and not for the part.

BUG: 313841

Test Plan

Press Ctrl + Shift + F in Yakuake, search bar opens

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Mar 1 2019, 7:11 PM
Restricted Application added a project: Konsole. · View Herald TranscriptMar 1 2019, 7:11 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
nicolasfella requested review of this revision.Mar 1 2019, 7:11 PM
nicolasfella edited the summary of this revision. (Show Details)Mar 1 2019, 7:12 PM

Thanks, my only concern is that the more shortcuts we add the more likely to conflict with the main app's shortcuts and there's no way to change/disable shortcuts in only the KonsolePart. This will cause issues (popup message) if the main app uses the same shortcut as KonsolePart.
Prior to this patch, only copy/paste and save/clear output and close session have default shortcuts in KonsolePart.

No necessarily a blocker, just a comment.

hindenburg accepted this revision.Mar 14 2019, 3:24 AM
hindenburg edited the summary of this revision. (Show Details)

Thanks, for conflicting shortcuts (dolphin), a dialog is shown - it can be resolved w/o much effort.

This revision is now accepted and ready to land.Mar 14 2019, 3:25 AM
This revision was automatically updated to reflect the committed changes.