DocumentPrivate: Respect indention mode when block selection
ClosedPublic

Authored by loh.tar on Mar 1 2019, 6:37 PM.

Details

Summary

Without this patch was in block selection mode always a tab inserted, also when
configured to use spaces on tab-key press

BUG: 395430
FIXED-IN: 5.58

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
loh.tar created this revision.Mar 1 2019, 6:37 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptMar 1 2019, 6:37 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
loh.tar requested review of this revision.Mar 1 2019, 6:37 PM
loh.tar updated this revision to Diff 56115.Sat, Apr 13, 8:39 AM
loh.tar edited the summary of this revision. (Show Details)
  • Rebase on master

No interest in this?
An autotest (place) for this may KateDocumentTest::testReplaceTabs, but not sure. There are slightly other things checked.

ngraham edited the summary of this revision. (Show Details)Sat, Apr 13, 5:02 PM
ngraham set the repository for this revision to R39 KTextEditor.
ngraham added reviewers: Kate, cullmann, dhaumann.

Just had not looked at this.
Looks reasonable, please push that.

cullmann accepted this revision.Sat, Apr 13, 5:17 PM
This revision is now accepted and ready to land.Sat, Apr 13, 5:17 PM
This revision was automatically updated to reflect the committed changes.