Differential D19448

Fix the conversion errors in Scale to New Size dialog
ClosedPublic
Actions

Authored by tymond on Mar 1 2019, 5:38 PM.

Details

Reviewers
rempt
Group Reviewers
Krita
Commits
R37:03db690749bc: Fix the conversion errors in Scale to New Size dialog
Summary

SpinBoxUnitManager used a function that not only converts units,
but also rounds them (for the View), hence the conversion errors.
This patch changes function to the precise one.

BUG:400177

Test Plan

Checking the Scale to New Size dialog to see whether the bug doesn't reproduce.
Checking whether it doesn't break other scale/resize/offset/crop dialogs and every other place
where the units are being used.

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tymond created this revision.Mar 1 2019, 5:38 PM
Restricted Application added a reviewer: Krita. · View Herald TranscriptMar 1 2019, 5:38 PM
Restricted Application added a project: Krita. · View Herald Transcript
tymond requested review of this revision.Mar 1 2019, 5:38 PM
rempt accepted this revision.Mar 2 2019, 9:19 AM
This revision is now accepted and ready to land.Mar 2 2019, 9:19 AM
Closed by commit R37:03db690749bc: Fix the conversion errors in Scale to New Size dialog (authored by tymond, committed by woltherav). · Explain WhyMar 2 2019, 11:06 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 52950

View Options

libs/widgetutils/kis_spin_box_unit_manager.cpp

Loading...