Logviewer: Fix MessageView not being visible
ClosedPublic
Actions

Authored by akulichalexandr on Mar 1 2019, 5:31 PM.

Details

Reviewers

davidedmundson

Group Reviewers

KDE Telepathy

Commits

Summary

Since Qt-5.11.1 (commit f8898170a77593e314d3cd187f259223e9bff0f8) the sizeHint() of MessageView returns 0x0 leading to zero width of the widget in splitter.

Test Plan

Before the patch:

MessageView is not visible no matter how wide the window is.

After the patch:

Repository

R154 KDE Telepathy Text User Interface

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

akulichalexandr requested review of this revision.Mar 1 2019, 5:31 PM

akulichalexandr created this revision.

akulichalexandr edited the test plan for this revision. (Show Details)

This revision is now accepted and ready to land.Mar 1 2019, 5:31 PM

Thanks, David, you're so incredibly fast!
I forgot to say that I want (going to) to land this to 18.12. I think it OK.

go for it

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			logviewer/log-viewer.cpp (7 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	52907			Mar 1 2019, 5:16 PM	★	★
Diff 2	52911	fdc5880	R154:fb9ae6d15030887ba9c256afa0ccb9f870e6a900	Mar 1 2019, 5:54 PM	★	★