[Kfilemetada] Make it compile without foreach
AbandonedPublic
Actions

Authored by mlaurent on Mar 1 2019, 12:14 PM.

Details

Reviewers

Commits

Summary

compile without foreach

Test Plan

Autotest ok

Repository

R286 KFileMetaData

Branch

compile_without_foreach (branched from master)

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 9019
Build 9037: arc lint + arc unit

Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript

mlaurent requested review of this revision.Mar 1 2019, 12:14 PM

This revision is now accepted and ready to land.Mar 1 2019, 12:26 PM

There are currently larger refactorings ongoing (D19287, D18826), could you please wait for them and rebase afterwards?

This clashes with D19287, and has to be rebased/merged then

This revision now requires changes to proceed.Mar 1 2019, 6:42 PM

This revision was not accepted when it landed; it landed in state Needs Revision.Mar 4 2019, 6:03 AM

This revision was automatically updated to reflect the committed changes.

Arg it was commited by error
I reverted it

Can be rebased/merged now ...

			Path	Packages
M			CMakeLists.txt (2 lines)
M			src/externalextractor.cpp (3 lines)
M			src/externalwriter.cpp (6 lines)
M			src/extractorcollection.cpp (13 lines)
M			src/extractorplugin.cpp (2 lines)
M			src/extractors/office2007extractor.cpp (2 lines)
M			src/extractors/taglibextractor.cpp (48 lines)
M			src/writercollection.cpp (11 lines)
M			tests/dump.cpp (2 lines)