Make NetworkManagerQt and BluezQt optional
ClosedPublic

Authored by heikobecker on Jun 18 2016, 8:43 AM.

Details

Summary

While it is most certainly sensible and helpful on a system equipped
with Bluetooth and Wi-Fi hardware, it serves no purpose on a desktop
system without these and just pulls in a long chain of unwanted
dependencies.

Test Plan

Successfully built with BluezQt and NetworkManagerQt present and missing.

Diff Detail

Repository
R122 Powerdevil
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
heikobecker updated this revision to Diff 4604.Jun 18 2016, 8:43 AM
heikobecker retitled this revision from to Make NetworkManagerQt and BluezQt optional.
heikobecker updated this object.
heikobecker edited the test plan for this revision. (Show Details)
heikobecker added reviewers: Plasma, broulik.
Restricted Application added a project: Plasma. · View Herald TranscriptJun 18 2016, 8:43 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik edited edge metadata.Jun 18 2016, 9:28 AM
broulik added a subscriber: jgrulich.

We've been through the "make action optional" dance with DPMS in the past and it has been a maintenance nightmare.

The action checks for whether you're allowed to enable/disable WiFi or else it won't show up. It seems it doesn't check for the existance of such hardware (except if the former implies the latter). This needs to be fixed, @jgrulich

We've been through the "make action optional" dance with DPMS in the past and it has been a maintenance nightmare.

Sure, in the end you're the maintainer.

The action checks for whether you're allowed to enable/disable WiFi or else it won't show up. It seems it doesn't check for the existance of such hardware (except if the former implies the latter). This needs to be fixed, @jgrulich

That still would require said libraries and their dependencies, wouldn't it?

That still would require said libraries and their dependencies, wouldn't it?

Yes. What dependencies are causing problems for you?

Yes. What dependencies are causing problems for you?

NetworkManager and its dependencies mostly. If I compare the situation to kwin and kscreenlocker, for example, and its hard dependency on wayland there's an obvious benefit and wayland is rather small in size and dependencies.

Here I would install a bunch of software I would never use on my desktop and probably would even have to blacklist some parts of it in systemd, before it's started automagically and messes up my normal config (and yes, sadly that happened before).

broulik accepted this revision.Jun 18 2016, 12:27 PM
broulik edited edge metadata.

Fair enough.

This revision is now accepted and ready to land.Jun 18 2016, 12:27 PM
This revision was automatically updated to reflect the committed changes.

We already have a feature and dependency freeze in place. This should not have gone into the Plasma/5.7 branch!

cfeck added a subscriber: cfeck.Jun 18 2016, 1:51 PM

We already have a feature and dependency freeze in place. This should not have gone into the Plasma/5.7 branch!

This patch does not add any dependencies (or raises their minimum version).

In D1944#35827, @cfeck wrote:

We already have a feature and dependency freeze in place. This should not have gone into the Plasma/5.7 branch!

This patch does not add any dependencies (or raises their minimum version).

It's still an invasive change and we don't have any releases before 5.7 final.