Change entry of Endpoint UI
ClosedPublic

Authored by andersonbruce on Mar 1 2019, 5:09 AM.

Details

Summary

BUG: 403548

Entry of the Endpoint was originally done in only
one LineEdit which included both the host and port
number. This update changes this so the host (as either
an IPv4, IPv6, or Fully Qualified Domain Name) is
entered in one LineEdit while the port number is
specified in another.

Diff Detail

Repository
R116 Plasma Network Management Applet
Branch
EndPointUIChange
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9267
Build 9285: arc lint + arc unit
andersonbruce created this revision.Mar 1 2019, 5:09 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 1 2019, 5:09 AM
Restricted Application added a reviewer: jgrulich. · View Herald Transcript
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
andersonbruce requested review of this revision.Mar 1 2019, 5:09 AM

Shouldn't we maybe use QSpinBox for the port? With the spinbox you can also set min and max values so you don't need to validate it.

Shouldn't we maybe use QSpinBox for the port? With the spinbox you can also set min and max values so you don't need to validate it.

My preference is to only use a spinbox for entries with less than 100 possible values. I believe that the up/down arrows give the impression that clicking on them is the "proper" method of selecting a value and while some people know that you can type in a value into a spinbox, I believe that there are others who do not and I really don't want users to be metaphorically cursing my name when they are trying to click their way up to a port number of say, 23517. Also, using a simple LineEdit with color coding for indicating an unacceptable input is consistent with the rest of the interface.

ngraham added a subscriber: ngraham.Mar 3 2019, 2:15 PM

My preference is to only use a spinbox for entries with less than 100 possible values. I believe that the up/down arrows give the impression that clicking on them is the "proper" method of selecting a value and while some people know that you can type in a value into a spinbox, I believe that there are others who do not and I really don't want users to be metaphorically cursing my name when they are trying to click their way up to a port number of say, 23517.

I would tend to agree.

Shouldn't we maybe use QSpinBox for the port? With the spinbox you can also set min and max values so you don't need to validate it.

My preference is to only use a spinbox for entries with less than 100 possible values. I believe that the up/down arrows give the impression that clicking on them is the "proper" method of selecting a value and while some people know that you can type in a value into a spinbox, I believe that there are others who do not and I really don't want users to be metaphorically cursing my name when they are trying to click their way up to a port number of say, 23517. Also, using a simple LineEdit with color coding for indicating an unacceptable input is consistent with the rest of the interface.

In that case you can use https://doc.qt.io/qt-5/qlineedit.html#inputMask-prop to limit what users can type there. You can also assign validators to other lineedits so users will be able to type only correct values.

  • Add validator for Endpoint Port field

Shouldn't we maybe use QSpinBox for the port? With the spinbox you can also set min and max values so you don't need to validate it.

My preference is to only use a spinbox for entries with less than 100 possible values. I believe that the up/down arrows give the impression that clicking on them is the "proper" method of selecting a value and while some people know that you can type in a value into a spinbox, I believe that there are others who do not and I really don't want users to be metaphorically cursing my name when they are trying to click their way up to a port number of say, 23517. Also, using a simple LineEdit with color coding for indicating an unacceptable input is consistent with the rest of the interface.

In that case you can use https://doc.qt.io/qt-5/qlineedit.html#inputMask-prop to limit what users can type there. You can also assign validators to other lineedits so users will be able to type only correct values.

This has been done.

jgrulich accepted this revision.Mar 15 2019, 12:46 PM
This revision is now accepted and ready to land.Mar 15 2019, 12:46 PM
This revision was automatically updated to reflect the committed changes.