Fixes wrong temp file creation (missing '/' at
relative root of mounted fs).
Details
Details
- Reviewers
dfaure chinmoyr - Group Reviewers
Frameworks Dolphin - Commits
- R241:ef5b9c6991aa: Fix upper/lower case rename on case insensitive fs
Mount a CIFS share e.g. at /mnt/share with option
'nocase'. In dolphin, go there and create a file
'foo' (i.e. /mnt/share/foo).
Try to rename it to 'Foo': Without this patch a
dialog pops up telling you about overwriting the file.
With this patch applied it will correctly be renamed.
Create a directory 'subdir' below /mnt/share.
In dolphin, change there and create a file 'foo'
(i.e. /mnt/share/subdir/foo).
Try to rename it to 'Foo': no problem with and without
this patch.
Diff Detail
Diff Detail
- Repository
- R241 KIO
- Branch
- fix_case_rename
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 9116 Build 9134: arc lint + arc unit
src/core/copyjob.cpp | ||
---|---|---|
1908 | IMO QDir isn't required here. QLatin1String("/kio_xxxxxx") is sufficient. |
Comment Actions
Indeed, "just" a missing slash.
Porting error in my commit bbf6181f4de7bc315c7c64e7528a3150788eea09 7 years ago (!)
I removed KUrl::AppendTrailingSlash and didn't actually a '/' :(