Differential D19419

[KdePlasma-Addons/POTD/NOAA] Fixed RegEx string to suit latest changes on the webpage
Needs ReviewPublic
Actions

Authored by tagorechandanreddy on Feb 28 2019, 1:19 PM.

Details

Reviewers
ngraham
davidedmundson
Summary

'Image of the day' has a new landing page everyday. This patch fixes the RegEx string that fetches the web address of the landing page.

Test Plan

All plugins should work as usual.

Diff Detail

Repository
R114 Plasma Addons
Lint
Lint Skipped
Unit
Unit Tests Skipped
tagorechandanreddy requested review of this revision.Feb 28 2019, 1:19 PM
tagorechandanreddy created this revision.
ngraham added a comment.Mar 4 2019, 3:46 AM

Can you clarify what problem we're solving here? The NOAA picture of the day wallpaper currently works just fine for me.

tagorechandanreddy added a comment.Mar 4 2019, 6:53 AM

The HTML of the webpage is updated with random whitespace characters and newline characters. Henceforth, this patch handles any such changes.

ngraham added a comment.Mar 4 2019, 4:01 PM
In D19419#424176, @tagorechandanreddy wrote:

The HTML of the webpage is updated with random whitespace characters and newline characters.

But does that make it actually not work at the moment?

tagorechandanreddy added a comment.Mar 4 2019, 5:31 PM

This patch is meant to be a more complete solution to handle the random HTML changes on the webpage. Without this patch, the plugin fails on odd occasions as the webpage gets updated daily.

davidedmundson added inline comments.Mar 5 2019, 10:19 PM
dataengines/potd/noaaprovider.cpp
93

Why are we losing multiline?

tagorechandanreddy marked an inline comment as done.Mar 5 2019, 10:30 PM
tagorechandanreddy added inline comments.
dataengines/potd/noaaprovider.cpp
93

The new string pattern doesn't need Multiline option. It handles newline character.

Revision Contents
Changeset List

PathPackages
Mdataengines/potd/noaaprovider.cpp (4 lines)

Diff 52824

View Options

dataengines/potd/noaaprovider.cpp

Loading...