Restore the search wrapped message to its former type and position.
ClosedPublic

Authored by rjvbb on Feb 28 2019, 12:37 PM.

Details

Summary

This fixes issue 398731 by restoring the "search wrapped" info message to its former type and position.

BUG: 398731

Test Plan

works as intended (= as before #cc8b2208)

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rjvbb created this revision.Feb 28 2019, 12:37 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptFeb 28 2019, 12:37 PM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
rjvbb requested review of this revision.Feb 28 2019, 12:37 PM

I'm in favor of this. Ever since the message was moved to the middle of the screen, it's annoyed me by covering up the search result itself. If the bottom-right corner is considered too hidden, maybe it should be horizontally centered, and moved up 50 pixels or so from the bottom of the view? But anything's better than covering up the found matches. :)

Also +1 for using the "Information" style rather than "Positive". That seems semantically correct to me.

I quote myself from D19367 TEST PLAN Potential TODOs:

There is a status (KSqueezedTextLabel) set in indicateMatch, but I have never seen this hint. Tinker the UI file make it visible. Not so bad. Do anyone knows why this is still there? May that be better to use instead of the fancy in-view-hint which is sometimes annoying because it hides the text? ... PowerUi would need such label too.

No, do not want so say that this label is better, just for info.

dhaumann accepted this revision.Feb 28 2019, 8:47 PM
dhaumann added subscribers: neundorf, dhaumann.

@neundorf With this we are back to where we came from. Interesting to see how history repeats, and repeats, and repeats... Accepting this change means a wont-fix to your wish to move it to the center.

@loh.tar The line edit in the search bar was once used before the floating message widgets in the view even existed. I guess it's legacy and possibly can be removed?

This revision is now accepted and ready to land.Feb 28 2019, 8:47 PM
rjvbb added a comment.Feb 28 2019, 9:06 PM
@loh.tar The line edit in the search bar was once used before the floating message widgets in the view even existed. I guess it's legacy and possibly can be removed?

You don't mean the widget through which you enter the pattern to search on I hope?

@loh.tar The line edit in the search bar was once used before the floating message widgets in the view even existed. I guess it's legacy and possibly can be removed?

You don't mean the widget through which you enter the pattern to search on I hope?

That quote reads a little strange. There is a label right from the line edit, now always hidden.

I had talked with Christoph and Dominik elsewhere to modify this wrap message in a way to only be shown when the start position is wrapped, but not top/bottom of the document.
That will reduce the times this message can be annoying and for my taste is a much more useful hint.

This revision was automatically updated to reflect the committed changes.