Differential D19406

[autotests] Fix race condition in ShellClient::testUnresponsiveWindow
ClosedPublic
Actions

Authored by davidedmundson on Feb 28 2019, 2:09 AM.

Details

Reviewers
zzag
Group Reviewers
KWin
Commits
R108:768e5fb7f422: [autotests] Fix race condition in ShellClient::testUnresponsiveWindow
Summary

The test executable "kill" freezes itself after 1ms, supposedly after
showing a window.

However showing a window is not syncronous on wayland, it's illegal to
map a buffer before getting a configure event from the server.

This patch removes any potential for a race by having the server tell
our test executable when to freeze.

Test Plan

Test still passed

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Feb 28 2019, 2:09 AM
Restricted Application added a project: KWin. · View Herald TranscriptFeb 28 2019, 2:09 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Feb 28 2019, 2:09 AM
zzag accepted this revision.Feb 28 2019, 8:46 AM
This revision is now accepted and ready to land.Feb 28 2019, 8:46 AM
Closed by commit R108:768e5fb7f422: [autotests] Fix race condition in ShellClient::testUnresponsiveWindow (authored by davidedmundson). · Explain WhyFeb 28 2019, 11:52 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 52800

View Options

autotests/integration/helper/kill.cpp

Loading...
View Options

autotests/integration/shell_client_test.cpp

Loading...