[RFC] Defuse KateMainWindow::showModOnDiskPrompt
ClosedPublic

Authored by loh.tar on Feb 27 2019, 8:31 PM.

Details

Summary

BUG:351443
BUG:375725

Test Plan

Fixed in a way as suggested in bug report.

Expected Results:  
Exit without asking (file was not edited since last time in kate, so there is no info to lose)

This dialog is for me pretty confusing and annoying.

  • In which case may that question (without this patch) useful?
  • Why should I reload a file when I like to close Kate?
  • Click "Ignore" you will asked again, where you can overwrite the file on disk. The opposite from your first intend.
  • Click "Diff" keeps the dialog the focus with the result that you can't scroll in the loaded diff. With dark theme is it hard to read too
  • You can end in some "endless" dialog boxes

So, how about to remove that dialog?

BUG:375725 Same issue, different request

Diff Detail

Repository
R40 Kate
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
loh.tar created this revision.Feb 27 2019, 8:31 PM
Restricted Application added a project: Kate. · View Herald TranscriptFeb 27 2019, 8:31 PM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
loh.tar requested review of this revision.Feb 27 2019, 8:31 PM
loh.tar edited the summary of this revision. (Show Details)Feb 27 2019, 8:55 PM
loh.tar edited the test plan for this revision. (Show Details)
loh.tar edited the summary of this revision. (Show Details)Mar 4 2019, 1:38 AM
ngraham added a subscriber: ngraham.Mar 4 2019, 4:04 AM

Oh this will be so nice to have fixed!

cullmann accepted this revision.Mar 4 2019, 6:52 PM
cullmann added a subscriber: cullmann.

Makes sense.

This revision is now accepted and ready to land.Mar 4 2019, 6:52 PM
This revision was automatically updated to reflect the committed changes.

Surprising quickly commited. There was some questions.