[wayland] Implement belongsToDesktop check
ClosedPublic

Authored by zzag on Feb 27 2019, 11:57 AM.

Details

Summary

When user asks KWin to show desktop, the compositor just raises every
desktop window, it doesn't attempt to minimize normal clients, etc.
Because desktop windows contain stuff like background and icons, the
compositor has to raise all clients that are somehow correlated with
desktop (e.g. panels, etc). Otherwise it would pretty weird to show only
desktop background.

Currently, not all plasmashell's clients are raised when the compositor
shows desktop because belongsToDesktop is not implemented for ShellClient.

BUG: 404801

Test Plan
  • Show desktop;
  • Open Kickoff (without this patch Kickoff is not visible).

Diff Detail

Repository
R108 KWin
Branch
keep-plasmashell-clients-above-during-show-desktop
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8933
Build 8951: arc lint + arc unit
zzag created this revision.Feb 27 2019, 11:57 AM
Restricted Application added a project: KWin. · View Herald TranscriptFeb 27 2019, 11:57 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Feb 27 2019, 11:57 AM
davidedmundson accepted this revision.Feb 27 2019, 1:51 PM
This revision is now accepted and ready to land.Feb 27 2019, 1:51 PM
This revision was automatically updated to reflect the committed changes.