[sddm-theme] Add a bottom panel
AbandonedPublic

Authored by filipf on Feb 26 2019, 11:57 PM.

Details

Reviewers
ngraham
rooty
Group Reviewers
VDG
Plasma
Summary

As a dependent revision of D19369, this patch adds a panel to the bottom in order to make sure the buttons found there are legible.

Test Plan

Before:

After:

Diff Detail

Repository
R120 Plasma Workspace
Branch
sddm-theme-panel (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8917
Build 8935: arc lint + arc unit
filipf created this revision.Feb 26 2019, 11:57 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 26 2019, 11:57 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Feb 26 2019, 11:57 PM
filipf edited the test plan for this revision. (Show Details)Feb 27 2019, 12:03 AM
filipf added reviewers: VDG, Plasma, ngraham.
rooty added a comment.EditedFeb 27 2019, 12:16 AM

Hey can you please rename the footer background to footerBackground because footer's used elsewhere

id: footer

to

id: footerBackground

And rename footerLayout back to footer, because it's used in sddm (Connections, line 355).
Also, you might want to add footerBackground.opacity = 0 there as well.

One more thing - it's a little dark, how's opacity: 0.6 sound (I'd prefer that we set the same opacity we'll be using for the action button backgrounds).

P.S. Indent the lines too :D

ndavis added a subscriber: ndavis.Feb 27 2019, 9:11 AM

-1

I don't think it looks very nice. If you're worried about those UI elements not being visible, wouldn't it be better to move them towards the center? Then, if it's necessary, you can add a background to all the floating UI elements so that they're all visible.

rooty added a comment.EditedFeb 27 2019, 9:28 AM

-1

I don't think it looks very nice. If you're worried about those UI elements not being visible, wouldn't it be better to move them towards the center? Then, if it's necessary, you can add a background to all the floating UI elements so that they're all visible.

Center how? Vertically?
Where would the elements be placed (with respect to the Clock / user names/avatars / action buttons)?

I would prefer something less intrusive like a gradient.

wouldn't it be better to move them towards the center?

People not finding the keyboard layout button and other controls tucked in the corners came up a lot in the past, so that could be a good idea.

I would prefer something less intrusive like a gradient.

wouldn't it be better to move them towards the center?

People not finding the keyboard layout button and other controls tucked in the corners came up a lot in the past, so that could be a good idea.

Sounds good. Is there a way to introduce some blur too? Or would that be too tacky?

The bottom panel was always my least favorite element of my previous design and I share others' reservations. +1 for the idea of making these more like the actionbuttons, and putting them closer to the center of the UI with their own backgrounds.

Center how? Vertically?
Where would the elements be placed (with respect to the Clock / user names/avatars / action buttons)?

Horizontally and maybe vertically. They could fit in the area above or below the Suspend, Reset, Shut Down, Other buttons.

abetts added a subscriber: abetts.Feb 27 2019, 3:16 PM

Back in the day, when I proposed changes to these elements, I put them on the center. People said that it looked crowded, boring, etc... However, my reasoning was because the selections are too far in the corners. It wasn't a problem with smaller older screens but it would become a problem with ultra-wide, 4K monitors, etc. The options would be too far from the center where the user is. I don't know that the bar at the bottom is a good solution overall. But it does bring attention to the area.

I can help with defining how they can look in the center?

filipf planned changes to this revision.Feb 27 2019, 7:42 PM

I can help with defining how they can look in the center?

That would be of great help, please do. I agree there could be better solutions than a panel.

filipf abandoned this revision.Mar 2 2019, 8:02 AM

Parent dependency was abandoned.