[sddm-theme] Add circles behind action buttons
AbandonedPublic

Authored by filipf on Feb 26 2019, 9:04 PM.

Details

Reviewers
ngraham
rooty
Group Reviewers
VDG
Plasma
Summary

As a dependent revision of D19369, this patch adds a circle behind action button icons in order to make sure they are legible.

Test Plan

Before:

After:

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8906
Build 8924: arc lint + arc unit
filipf created this revision.Feb 26 2019, 9:04 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 26 2019, 9:04 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Feb 26 2019, 9:04 PM
filipf edited the summary of this revision. (Show Details)Feb 26 2019, 9:12 PM
filipf edited the test plan for this revision. (Show Details)
filipf added reviewers: VDG, ngraham, Plasma.
filipf edited reviewers, added: rooty; removed: Plasma.Feb 27 2019, 12:11 AM
filipf added a reviewer: Plasma.

1 and 0.9 are too dark imo, we should aim for lower values

ngraham added inline comments.Feb 27 2019, 2:28 PM
lookandfeel/contents/components/ActionButton.qml
46

How about 0.9 and 0.7?

Oh one more thing: the ActionButton component is also used in the logout screen. Does this look good there too when the background is dark, or does it become kind of muddy?

The way we solved this in the old version was by adding a light-colored outline around the circle to provide contrast when the background is also dark. I'd recommend that we do that here too, or else make the background circle optional and omit it on the logout screen when its background is dark.

filipf abandoned this revision.Mar 2 2019, 8:01 AM

Parent dependency was abandoned.